Replace activity query with new API endpoint #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickeyn
commented
May 31, 2017
| { terms => { status => [qw< cpan latest >] } }, | ||
| ); | ||
| } | ||
| my %args = map { $_ => $c->req->parameters->{$_} } |
There was a problem hiding this comment.
@oalders wasn't sure whether to create a new hash with the args or just pass $c->req->parameters to request - what do you think?
There was a problem hiding this comment.
Good call. I think that's a good way to handle it.
oalders
approved these changes
May 31, 2017
| { terms => { status => [qw< cpan latest >] } }, | ||
| ); | ||
| } | ||
| my %args = map { $_ => $c->req->parameters->{$_} } |
There was a problem hiding this comment.
Good call. I think that's a good way to handle it.
API now provides a new endpoint for activity info, we don't need to send a query from WEB anymore.
mickeyn
force-pushed
the
mickey/use_new_activity_ep
branch
from
48b3c8e
to
7fc5e58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API now provides a new endpoint for activity info, we don't
need to send a query from WEB anymore.