Switch from AnyEvent to IO::Async #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
force-pushed
the
haarg/io-async
branch
2 times, most recently
from
5878e7c
to
bf533c5
Compare
|
I pulled some changes from this PR out into #1915 because they are simpler and don't rely on this. Will rebase this once that PR is merged. |
|
@haarg merged |
IO::Async and Future are friendlier to work with and more perl-ish.
mickeyn
approved these changes
Jun 13, 2017
|
The sitemap changes could maybe go in a separate PR, but to handle it sensibly it would have to depend on this one, and require an additional cpanfile.snapshot regeneration. The existing sitemap code doesn't even work properly, and we aren't running it on the servers. |
|
it's OK with me (i'm known to combine several issues in single PRs :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use AnyEvent to run multiple HTTP requests simultaneously. This converts those to using Net::Async::HTTP. All of the API model methods have been changed to consistently return futures that can be fetched with
->get, which should make it easier to clean up how we are using concurrent requests.Additionally includes a rewrite of the site map generation to something that should actually work, and some other prereq cleanups.