refactor and improve file sorting on release page #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickeyn
reviewed
Jul 7, 2017
| my @modules | ||
| = is_arrayref( $f->{module} ) ? @{ $f->{module} } : $f->{module}; | ||
| for my $module ( grep {defined} @modules ) { | ||
| for my $f ( @files{@files} ) { |
There was a problem hiding this comment.
isn't this just values %files? i don't see any code changing the hash or the array.
There was a problem hiding this comment.
Left over from refactoring where I wanted sorting or removed items from @files. It could just be values in this case.
Move all file sorting into one routine. Only link one one of a matching pod/pm pair. Allow for other interesting files that aren't in the root directory.
haarg
force-pushed
the
haarg/release-file-organizing
branch
from
2e278e4
to
84f1880
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all file sorting into one routine. Only link one one of a matching
pod/pm pair. Allow for other interesting files that aren't in the root
directory.