Refactor to better export oas30 and oas31 compatible with cjs

[pjmolina]

Refactor to better export oas30 and oas31 compatible with cjs
(it will break compatibility in the way we export).

Can you take a look @RobinTail is this solves your use case?

[RobinTail]

I hope so.
In order to make sure, I need to clone and build it.
I'll check try to check ASAP

[RobinTail]

this approach does not work for some reason

TS2614: Module '"openapi3-ts"' has no exported member 'oas30'. Did you mean to use 'import oas30 from "openapi3-ts"' instead?

[RobinTail]

maybe need to clean cache... please wait....

[pjmolina]

Yes. Looks like a typo on my side.
Can you confirm this works for you?

import oas30 from "openapi3-ts";

[RobinTail]

this would import the whole object (default) giving it the name oas30. Similar to import lib from "openapi3-ts" approach.

The object itself is OK.

I believe the export from index.ts should be done in a slighlty different way.

[RobinTail]

I found the reason, see my suggestion below, @pjmolina

[RobinTail]

I believe these two guys should also be exported (not within the "default"), then they will be importable individually, @pjmolina

Suggested change

	const oas30 = { ...model.oas30, ...dsl.oas30 };
	const oas31 = { ...model.oas31, ...dsl.oas31 };
	export const oas30 = { ...model.oas30, ...dsl.oas30 };
	export const oas31 = { ...model.oas31, ...dsl.oas31 };

[RobinTail]

I'm going to try it locally and then I'll confirm.

[RobinTail]

Yes, I confirm, with this approach individual imports do work

[RobinTail]

However, this does not solve the import problem for types (from model)

[RobinTail]

perhaps these entities (oas30 and oas31) should be namespaces, not constants.
Thus, they could also contain types ("model")

[RobinTail]

I'm going to take a bit time to prepare a better suggestion

[RobinTail]

Ok. I have a proprosition that I believe solves everything. Without namespaces, but using the power of modules.

The approach is based on a different way of combining entities comparing to the one you have currently.

1. Instead of src/dsl/index.ts and src/model/index.ts there are two files for each module

src/oas30.ts:

export * from './dsl/openapi-builder30';
export * from './model/openapi30';
export { Server, ServerVariable } from './model/server';
export { IExtensionName, IExtensionType, ISpecificationExtension } from './model/specification-extension';

src/oas31.ts:

export * from './dsl/openapi-builder31';
export * from './model/openapi31';
export { Server, ServerVariable } from './model/server';
export { IExtensionName, IExtensionType, ISpecificationExtension } from './model/specification-extension';

2. Then your src/index.ts file becomes this beauty:

export * as oas30 from "./oas30";
export * as oas31 from "./oas31";
export { Server, ServerVariable } from "./model/server"

no default export, only oas30 , oas31 , Server and ServerVariable
@pjmolina

[RobinTail]

Maybe I should create another PR for that?

[pjmolina]

Maybe I should create another PR for that?

Sure! Feel free. I will review and comment tomorrow. Thanks

[pjmolina]

Rejecting this PR in favour of: PR #104 by @RobinTail