Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional types for production if provided via options. #16

Merged
merged 1 commit into from May 28, 2018

Conversation

pjmolina
Copy link
Contributor

issue #11
Implements optional output type information via options.

@pjmolina pjmolina changed the title Added optional types for production if provided via options. issue #11 Added optional types for production if provided via options. May 26, 2018
Copy link
Contributor

@StoneCypher StoneCypher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly for it

the only change i would make is before line 733, i'd do something like

const opts = typeof options === string? { parse: options } : options;

then work off opts, as a convenience for people who only want to add types to parse/n

but it's a minor convenience and unimportant

@pjmolina pjmolina merged commit 55345b7 into master May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants