Revise Ren-C's rules for CR and 0 bytes in strings #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tries to build on Rebol's historical concept of unifying strings within the system to use LF-only. But rather than try "magic" to filter out CR LF sequences (and "magically" put them back later), it adds in speedbumps to try and stop CR from casually getting into strings. Then it encourages active involvement at the source level with functions like ENLINE and DELINE when a circumstance can't be solved by standardizing the data sources themselves: https://forum.rebol.info/t/1264 It also revises Ren-C's rules to be prescriptive about disallowing 0 bytes in strings, to more safely use the rebSpell() API, which only returns a pointer and must interoperate with C. It enforces the use of BINARY! if you want to embed 0 bytes (and using the rebBytes() API, which always returns a size.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tries to build on Rebol's historical concept of unifying
strings within the system to use LF-only. But rather than try "magic"
to filter out CR LF sequences (and "magically" put them back later), it
adds in speedbumps to try and stop CR from casually getting into
strings. Then it encourages active involvement at the source level
with functions like ENLINE and DELINE when a circumstance can't be
solved by standardizing the data sources themselves:
https://forum.rebol.info/t/1264
It also revises Ren-C's rules to be prescriptive about disallowing 0
bytes in strings, to more safely use the rebSpell() API, which only
returns a pointer and must interoperate with C. It enforces the use of
BINARY! if you want to embed 0 bytes (and using the rebBytes() API,
which always returns a size.)