Use stack series instead of recursion for GC #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hostilefork
force-pushed
the
no-gc-recursion
branch
from
1b28ef6
to
633b653
Compare
|
Going ahead and merging this. I'd tested this more or less before, but the ROUTINE!/STRUCT! stuff doubled the size of the patch. I'm not testing the FFI code ATM (there are a couple of test for it, but this is just using the "stub"). So if there are problems let me know. |
hostilefork
force-pushed
the
no-gc-recursion
branch
from
633b653
to
2d5ab31
Compare
Addresses problem of C execution stack overflow when given
deeply nested blocks, such as this:
a: copy []
loop 200'000 [a: append/only copy [] a]
recycle
Works standalone whereas previously in r3 it would crash. Yet
test build crashes on this (and other things before it) and alerts
address sanitizer. So there are more things to be fixed.
hostilefork
force-pushed
the
no-gc-recursion
branch
from
2d5ab31
to
a2d1c8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses problem of C execution stack overflow when given
deeply nested blocks, such as this:
Works standalone whereas previously in r3 it would crash. Yet
test build crashes on this (and other things before it) and alerts
address sanitizer. So there are more things to be fixed.
To clear the air a bit, I got rid of the macros that just set flags
as names like MARK_SERIES are pretty nebulous as to how
much they do or don't do.