FORM non-STRING! (instead of non-ANY-STRING!) in FIND #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebol issue 1160 pointed out a problem with using a TAG! to search over a string: metaeducation/rebol-issues#1160 This change uses FORM on the argument, so `find "<abc>" <abc>` will account for the tag delimiters. Searching has some strange ramifications for other types, given that you can't really get a good result out of `find <abc> "<"`. For lack of a better rule, though, this goes ahead and FORMs. Also gets rid of the unimplemented wildcard features in FIND and SELECT, which are more suited to a PARSE or GLOB dialect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebol issue 1160 pointed out a problem with using a TAG! to search
over a string:
metaeducation/rebol-issues#1160
This change uses FORM on the argument, so
find "<abc>" <abc>willaccount for the tag delimiters.
Searching has some strange ramifications for other types, given that
you can't really get a good result out of
find <abc> "<". Forlack of a better rule, though, this goes ahead and FORMs.
Also gets rid of the unimplemented wildcard features in FIND and
SELECT, which are more suited to a PARSE or GLOB dialect.