Ren c ffi #62
Merged
Ren c ffi #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't see why zero-sized series should be requested, which usually indicates an error. Also because we might eventually call "malloc" to allocate memory, whose behivor on zero-sized allocation is implementation dependant. We better disallow it here. http://stackoverflow.com/questions/2022335/whats-the-point-in-malloc0
Call_Routine could run GC, which could have GC'ed args
As pointed out by @HostilFork, saving out form Do_* in an expandable series is unsafe: the pointer could become dangling if it expands. Because we don't [UN]SAVE_VALUE, use a length of 1 series for this purpose. MKS_LOCK is not necessary here, as it's clear that this series is not expanded, but in general, it should be used for series used for this purpose. The Data_Stack usage in callback_dispatcher should be fine. But, for consistency, it's also changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series makes gtk-demo.r runnable again.
MKS_LOCK flag might not be necessary, as it can be set after being created. But it's convenient, and it conceptually makes sense to lock down the series while it's being created.