Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docs/ for use in Github Pages #963

Merged
merged 1 commit into from Mar 19, 2019
Merged

Create docs/ for use in Github Pages #963

merged 1 commit into from Mar 19, 2019

Conversation

giuliolunati
Copy link

place there all replpad-js stuff
NB there is not and index.html
use replpad.html or template.html instead

@hostilefork
Copy link
Member

hostilefork commented Mar 19, 2019

I have wondered if a parts of the ReplPad that should be in the JavaScript extension. For instance, the JavaScript READ, JS-DO, CSS-DO, etc.

Then, I have wondered if there are parts of the ReplPad that should be in a "terminal" extension (to provide INPUT and WRITE-STDOUT).

Both of these would have to take for granted some amount of JS code, CSS, maybe HTML.

But I don't know that it's time to be doing this yet, so I don't think the ReplPad code (e.g. gui.js) should be moved into the main repository at this time.

(If your intent is just to have a copy as documentation, I don't want to do that--that is a copy that would be immediately out of sync.)

@giuliolunati
Copy link
Author

giuliolunati commented Mar 19, 2019

@hostilefork my intent is to host replpad-js in docs/ of main ren-c repository, and eventually serve it at Github Pages (and that's why I choose docs/)

@hostilefork
Copy link
Member

my intent is to host replpad-js in docs/ of main ren-c repository, and eventually serve it at Github Pages

I want you to have the freedom to do what experiments you need to get the loader in order. But if you want to do something like this, please do it with a git clone --depth=1 on Travis, or otherwise pulling replpad from where it lives, vs. making another copy in the repo...

@hostilefork
Copy link
Member

If you have to serve the replpad from GitHub for what you are doing, then perhaps a submodule can do that?

https://git-scm.com/book/en/v2/Git-Tools-Submodules

Though I'd really like the loader to be pulling everything it needs from S3, not GitHub

@giuliolunati
Copy link
Author

Ok, I understand. And if we host in docs/ only the load-r3.js stuff and activate Github Pages only for testing purposes, that's fine for you?

@hostilefork
Copy link
Member

hostilefork commented Mar 19, 2019

Ok, I understand. And if we host in docs/ only the load-r3.js stuff and activate Github Pages only for testing purposes, that's fine for you?

Activating GitHub pages is fine. I don't care how things are organized just yet, so long as every file is edited only in one place! :-)

place there load-r3.js and related stuff
@giuliolunati giuliolunati merged commit ca0d015 into master Mar 19, 2019
@giuliolunati giuliolunati temporarily deployed to github-pages March 19, 2019 12:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants