Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list for examples in PG #24

Merged
merged 16 commits into from
Nov 23, 2023
Merged

Add list for examples in PG #24

merged 16 commits into from
Nov 23, 2023

Conversation

TobiasNx
Copy link
Collaborator

@TobiasNx TobiasNx commented Jun 12, 2023

Add an example for every flux command

Related to metafacture/metafacture-core#488

@TobiasNx TobiasNx marked this pull request as ready for review November 7, 2023 13:35
@TobiasNx TobiasNx requested a review from dr0i November 7, 2023 13:36
@TobiasNx
Copy link
Collaborator Author

Do not merge this pr

@metafacture metafacture locked and limited conversation to collaborators Nov 13, 2023
@fsteeg
Copy link
Member

fsteeg commented Nov 15, 2023

Do not merge this pr

Dafür sind doch drafts da, siehe oben rechts, bei "Reviewers":

Still in progress? Convert to draft

@dr0i
Copy link
Member

dr0i commented Nov 20, 2023

If we simply omit the 3. column when we don't have an example to PG we would simply leave the link, see metafacture/metafacture-core#509 .

@dr0i
Copy link
Member

dr0i commented Nov 20, 2023

I think this definitely improves our documentation 👍 (see example in metafacture/metafacture-core#509).
If you are ok with leaving the 3. column empty we could merge this (possibly after metafacture/metafacture-core#509 is merged). We can consecutively improve this table.

@dr0i dr0i assigned TobiasNx and unassigned dr0i Nov 20, 2023
@TobiasNx TobiasNx marked this pull request as draft November 20, 2023 14:18
@TobiasNx
Copy link
Collaborator Author

Do not merge this pr

Dafür sind doch drafts da, siehe oben rechts, bei "Reviewers":

Still in progress? Convert to draft

But not via the Github app on my phone.

@TobiasNx
Copy link
Collaborator Author

Links need to be updated with: metafacture/metafacture-playground#148

@dr0i
Copy link
Member

dr0i commented Nov 20, 2023

I don't understand. I've implement to load a tsv. Now in metafacture/metafacture-playground#148 the examples are organized in different flat files?

@TobiasNx
Copy link
Collaborator Author

I will update the file! We talked about it two weeks ago, if we would prefer literal links like https://metafacture.org/playground/as-lines. For this we need the links in the playground.

@dr0i
Copy link
Member

dr0i commented Nov 20, 2023

ah - ok, good :)

@TobiasNx TobiasNx marked this pull request as ready for review November 23, 2023 13:30
@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Nov 23, 2023
@dr0i dr0i merged commit dd33893 into master Nov 23, 2023
@dr0i dr0i deleted the fluxExamples branch November 23, 2023 13:59
@dr0i
Copy link
Member

dr0i commented Nov 23, 2023

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants