Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28 use jekyll theme #43

Merged
merged 37 commits into from May 23, 2024
Merged

28 use jekyll theme #43

merged 37 commits into from May 23, 2024

Conversation

TobiasNx
Copy link
Collaborator

@TobiasNx TobiasNx commented Apr 24, 2024

@Phu2 redid the documentation, so that it works with the jekyll template. This changes the structure of the repo.
The markdown files are not at the toplevel anymore, but now in the /docsfolder and its subfolders.

Additionally I adjusted the README.md to fit the new structure.

We still should move and redo the maintainers guide so that it is not a page in the documentation. And document how to update the documentation but this can be done in a separate issue.

@fsteeg and @dr0i could you have a look. The render page also can be found here: http://metafacture.github.io/metafacture-documentation/

Phu2 and others added 27 commits March 27, 2024 12:09
to generate the desired navigation
Missing part for deciding which part of the documentation is relevant for you.
Update _config.yml for search
as create or update workflow is not allowed using personal access token
Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Added inline suggestions, mostly to fix relative links for the deployed location.

Additionally, links to the feature branch should be updated from 28-use-jekyll-theme to master before merging. I did not add suggestions for these to keep the links in the deployed version working, as it's not merged yet.

docs/Getting-Started.md Outdated Show resolved Hide resolved
docs/Getting-Started.md Outdated Show resolved Hide resolved
docs/Getting-Started.md Outdated Show resolved Hide resolved
docs/Getting-Started.md Outdated Show resolved Hide resolved
docs/Getting-Started.md Outdated Show resolved Hide resolved
docs/java-integration/java-integration.md Outdated Show resolved Hide resolved
docs/flux/flux.md Outdated Show resolved Hide resolved
index.md Outdated Show resolved Hide resolved
index.md Outdated Show resolved Hide resolved
index.md Outdated Show resolved Hide resolved
@fsteeg fsteeg removed their assignment May 17, 2024
docs/Getting-Started.md Outdated Show resolved Hide resolved
docs/Getting-Started.md Outdated Show resolved Hide resolved
@dr0i dr0i assigned TobiasNx and unassigned dr0i May 21, 2024
Co-authored-by: Fabian Steeg <steeg@hbz-nrw.de>
@TobiasNx TobiasNx requested a review from fsteeg May 21, 2024 14:44
@TobiasNx TobiasNx assigned fsteeg and unassigned TobiasNx May 22, 2024
docs/Getting-Started.md Outdated Show resolved Hide resolved
docs/Getting-Started.md Outdated Show resolved Hide resolved
docs/MF-in-5-min.md Outdated Show resolved Hide resolved
docs/LICENSE.md Outdated

MIT License

Copyright (c) 2022 just-the-docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the LICENSE here is confusing, since it's the Just the Docs license, not the Metafacture license (which is Apache 2). I think this can be removed here, or replaced with (a link to) the Metafacture license: https://github.com/metafacture/metafacture-core/blob/master/LICENSE

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I move the old LICENSE file up to root level and added the link to the MF License in the Navigation.

@fsteeg fsteeg assigned TobiasNx and unassigned fsteeg May 22, 2024
Co-authored-by: Fabian Steeg <steeg@hbz-nrw.de>
@TobiasNx TobiasNx requested a review from fsteeg May 22, 2024 12:34
@TobiasNx TobiasNx assigned fsteeg and unassigned TobiasNx May 22, 2024
Co-authored-by: Fabian Steeg <steeg@hbz-nrw.de>
@fsteeg fsteeg linked an issue May 23, 2024 that may be closed by this pull request
@fsteeg fsteeg merged commit 4241eac into master May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use jekyll theme for documentation
4 participants