Copy values in fix-list-values to support wildcard & index paths

See https://gitlab.com/oersi/oersi-etl/-/issues/238
metafacture · May 8, 2023 · 1d0fe7b · 1d0fe7b
1 parent 5927b7c
commit 1d0fe7b
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 4 deletions.
diff --git a/metafix/src/main/java/org/metafacture/metafix/MetafixListValues.java b/metafix/src/main/java/org/metafacture/metafix/MetafixListValues.java
@@ -36,7 +36,13 @@
 public class MetafixListValues extends MetafixStreamAnalyzer {
 
     public MetafixListValues(final String path) {
-        super("retain(\"" + path + "\")", Compare.OBJECT, "${o}\t ${s}", "${o}");
+        super(fix(path), Compare.OBJECT, "${o}\t ${s}", "${o}");
+    }
+
+    private static String fix(final String path) {
+        return
+            "copy_field(\"" + path + "\",\"value.$append\")\n" +
+            "retain(\"value\")";
     }
 
 }
diff --git a/metafix/src/test/java/org/metafacture/metafix/MetafixListValuesTest.java b/metafix/src/test/java/org/metafacture/metafix/MetafixListValuesTest.java
@@ -43,21 +43,48 @@ public MetafixListValuesTest() {
     }
 
     @Test
-    public void testShouldListPathsA() {
+    public void testShouldListPathsSimple() {
         lister = new MetafixListValues("a");
         verify("2\t aA");
     }
 
     @Test
-    public void testShouldListPathsB() {
+    public void testShouldListPathsWildcard() {
+        lister = new MetafixListValues("a.*");
+        verify("2\t aA");
+    }
+
+    @Test
+    public void testShouldListPathsIndex() {
+        lister = new MetafixListValues("a.1");
+        verify("1\t aA");
+    }
+
+    @Test
+    public void testShouldListPathsTwoValues() {
         lister = new MetafixListValues("b");
+        verify(
+                "2\t bB",
+                "1\t bA");
+    }
+
+    @Test
+    public void testShouldListPathsTwoValuesWildcard() {
+        lister = new MetafixListValues("b.*");
         verify(
             "2\t bB",
             "1\t bA");
     }
 
     @Test
-    public void testShouldListPathsC() {
+    public void testShouldListPathsTwoValuesIndex() {
+        lister = new MetafixListValues("b.1");
+        verify(
+            "1\t bB");
+    }
+
+    @Test
+    public void testShouldListPathsSortCount() {
         lister = new MetafixListValues("c");
         verify(
             "3\t cC",