Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VSC Extension #291

Closed
katauber opened this issue Mar 10, 2023 · 7 comments · Fixed by #297
Closed

Update VSC Extension #291

katauber opened this issue Mar 10, 2023 · 7 comments · Fixed by #297
Assignees

Comments

@katauber
Copy link
Member

katauber commented Mar 10, 2023

Due to changes in Metafacture Fix the VSC Extension should be updated by using the latest Fix version and adapting the syntax highlighting.
This can be used for functional review.
The pictures at https://metafacture.org/ide-extensions/index.html should be exchanged.

functional review: @TobiasNx
code review: @fsteeg

@katauber katauber self-assigned this Mar 10, 2023
@dr0i
Copy link
Member

dr0i commented Mar 27, 2023

I have added this issue to the Metafacture Projects so that it appears at our metafacture board at https://github.com/orgs/metafacture/projects/3/views/4.

@TobiasNx
Copy link
Collaborator

TobiasNx commented Mar 27, 2023

Things I noticed and would be nice:

some words as type and entity withou "" are highlighted in different style

replace_all, add_field, timestamp, isbn, lookup, substring are functions that differ from other function in style

Comments with # are not styled as such. (See: #4)

Block comments are not working * add_field("coll[].*.c", "test") */. : #129

@katauber
Copy link
Member Author

I uploaded the vsix file to our oi-austausch directory. For installation see the installation instructions

@TobiasNx
Copy link
Collaborator

TobiasNx commented May 2, 2023

grafik

Looks promising.

Two things I found option "var" in do list, is not highlighted as option, probably because of the "
join_field is not highlighted differently than other functions.

Perhaps binds (list etc. eveything with do in front of it) and conditionals (eveything with if/elif/unless in front of it) should be highlighted differently than function

@TobiasNx TobiasNx assigned katauber and unassigned TobiasNx May 2, 2023
@TobiasNx
Copy link
Collaborator

TobiasNx commented May 2, 2023

strange reaction to shebang:
grafik

@katauber
Copy link
Member Author

katauber commented May 8, 2023

Looks promising.

Two things I found option "var" in do list, is not highlighted as option, probably because of the "

Options are not highlighted. I think it's because of your theme that e.g. path is blue. In my theme it's white (not highlighted).

join_field is not highlighted differently than other functions.

That was also not highlighted because of a typo. Now it is.

Perhaps binds (list etc. eveything with do in front of it) and conditionals (eveything with if/elif/unless in front of it) should be highlighted differently than function

There are four groups: Fix controls (like do, if etc), fix methods (like inlcude, put_map etc), fix conditionals (like all_contain, any_contain etc) and Fix binds (like list, list_as etc). To highlight them in different colors I have to mark them as different groups according to this documentation. I am not really happy with this solution because I think that binds and methods should be both in the entity group and controls and conditionals also both in one group which would lead to having the same color.
But I can live with this solution.

strange reaction to shebang: grafik

I cannot reproduce this behaviour. I will put the new extension again in oi-austausch. Please test if it still behaves like this.

@katauber katauber assigned TobiasNx and unassigned katauber May 8, 2023
@TobiasNx TobiasNx assigned fsteeg and unassigned TobiasNx May 10, 2023
@TobiasNx
Copy link
Collaborator

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants