Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow urls with filemap #301

Closed
TobiasNx opened this issue May 10, 2023 · 2 comments · Fixed by #317
Closed

Allow urls with filemap #301

TobiasNx opened this issue May 10, 2023 · 2 comments · Fixed by #317
Assignees
@TobiasNx
Labels
enhancement New feature or request

Comments

@TobiasNx
Copy link
Collaborator

At the moment one can only refer to a local file via path for filemap.

It would be nice if we could support url, so that we could link to file on the web.

rdfmap already supports this.
@TobiasNx TobiasNx added the enhancement New feature or request label May 10, 2023
@dr0i dr0i assigned dr0i and TobiasNx and unassigned dr0i Jun 5, 2023
@TobiasNx
Copy link
Collaborator Author

TobiasNx commented Jun 21, 2023 •
edited

This was already supported by filemap in morph. See example here:
https://github.com/hbz/lobid-organisations/blob/master/conf/morph-enriched.xml#L468-L477

Also the labeling was filemap in morph there seemed to be no discussion about naming it urlmap or webmap.

@TobiasNx
Copy link
Collaborator Author

Also this would be useful for the fix transformation of lobid organisation.

dr0i added a commit that referenced this issue Jun 23, 2023
@dr0i
Allow lookup on URLs (#301)
33f2153 
Comlies with metafacture-core.

- increase max value of ClassDataAbstractionCoupling in checkstyle
- implement test
dr0i added a commit that referenced this issue Jun 23, 2023
@dr0i
Allow lookup on URLs (#301)
2a4c259 
Comlies with metafacture-core.

- increase max value of ClassDataAbstractionCoupling in checkstyle
- implement test
dr0i added a commit that referenced this issue Jun 23, 2023
@dr0i
Allow lookup on URLs (#301)
2edee57 
Comlies with metafacture-core.

- increase max value of ClassDataAbstractionCoupling in checkstyle
- implement test
dr0i added a commit that referenced this issue Jun 23, 2023
@dr0i
Allow lookup on URLs (#301)
48ee14b 
Complies with metafacture-core.

- increase max value of ClassDataAbstractionCoupling in checkstyle
- implement test
@dr0i dr0i mentioned this issue Jun 23, 2023
Closed
dr0i added a commit that referenced this issue Jun 26, 2023
@dr0i
Update checkstyle (#301)
9dcbd46 
- Check if a whitespace is followed when doing '//' comments
- update checkstyle dependency which is last java 8 compatible one
dr0i added a commit that referenced this issue Jun 26, 2023
@dr0i
Improve naming of variables; make them final (#301)
eef131a
dr0i added a commit that referenced this issue Jun 26, 2023
@dr0i
Update README (#301)
26c2002 
Complements 48ee14b.
dr0i added a commit that referenced this issue Jun 27, 2023
@dr0i
Allow lookup on URLs (#301)
755c7d1 
Complies with metafacture-core.

- disable ClassDataAbstractionCoupling checkstyle in Metafix
- implement test
- update README
dr0i added a commit that referenced this issue Jun 27, 2023
@dr0i
Allow lookup on URLs (#301)
6fe3a71 
Complies with metafacture-core.

- disable ClassDataAbstractionCoupling checkstyle in Metafix
- implement test
- update README
@dr0i dr0i mentioned this issue Jun 27, 2023
Merged
@dr0i dr0i closed this as completed in #317 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TobiasNx TobiasNx

Labels
enhancement New feature or request
Projects
Metafacture
Status: Done
Milestone
No milestone
2 participants
@dr0i @TobiasNx