Add support for nested paths in retain() Fix function.
#329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackwinter
force-pushed
the
145-retainNested
branch
from
ea84ee3
to
45bb75b
Compare
|
Looks good, tested a buch of variations. It seems that $last and $first are not supported yet. |
|
Thanks. Implemented in 5cc686d. |
|
@fsteeg: There's quite some overlap with |
The adjustments seem to work +1 |
|
@fsteeg did you see this review-request? |
fsteeg
approved these changes
Nov 20, 2023
Sorry, seems I missed it, thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #145.