Fix "cannot read property '0' of undefined" in case of lost data race #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using flickity together with another widget/ui framwork. This seems to cause some kind of data race where the navCompanion is not really "ready" when the first navCompanionSelect happens. When this happes `navCompanion.selectedCells` is still undefined and accessing it throws an TypeError. This check prevents that. On our tests it behaves exactly the same as before, but without throwing the error.
|
Thank you for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using flickity together with another widget/ui framwork. This seems to cause some kind of data race where the navCompanion is not really "ready" when the first navCompanionSelect happens.
When this happes
navCompanion.selectedCellsis still undefined and accessing it throws an TypeError. This check prevents that. On our tests it behaves exactly the same as before, but without throwing the error.