Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slider drag stops working if index variable passed is not of type int… #260

Closed
wants to merge 1 commit into from

Conversation

cioddi
Copy link

@cioddi cioddi commented Oct 6, 2015

…eger

To avoid this case (and save people running into it a lot of time :)) I propose to just call parseInt on the passed parameter.

example: http://codepen.io/anon/pen/NGjgqR

…eger

To avoid this case (and save people running into it a lot of time :)) I propose to just call parseInt on the passed parameter.

example: http://codepen.io/anon/pen/NGjgqR
@cioddi
Copy link
Author

cioddi commented Oct 6, 2015

I would like to add. Of course this is not a real bug.
But the problem is that it seems to work at first (while it assigns a string value to this.selectedIndex) and then you realize that the drag slide functionality is gone.
So it should either throw some kind of error and do nothing or parse the value to int and just work.

@desandro desandro closed this in 74e55b3 Oct 9, 2015
@desandro
Copy link
Member

desandro commented Oct 9, 2015

Good call! Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants