Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added weather teller #26

Merged
merged 2 commits into from Oct 2, 2022
Merged

added weather teller #26

merged 2 commits into from Oct 2, 2022

Conversation

srinjoy-26
Copy link
Contributor

@srinjoy-26 srinjoy-26 commented Sep 30, 2022

Description

Added a script which can tell the weather of a place .

Fixes #20

Dependencies

pycharm , python 3.10 , weather API

Future Improvements

detect weather

Mentions

@advaita-saha

Screenshots of relevant screens

weather.mp4

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR

@github-actions
Copy link
Contributor

Thank you for opening your first pull request in our repository, one of our maintainers will get in touch with you soon.

We at Metafy have some special rewards and swags for the top contributors in general repos and every contributor in web3 repos
For being eligible for that, please authenticate yourself using this link:
https://hacktoberfest.auth.metafy.social

Rewards : T-shirts & NFT ( for blockchain contributions )

Best of luck on your Contributions
For further queries you can join our discord for support : https://discord.gg/W6PmEjjQsA

@advaita-saha
Copy link
Collaborator

@srinjoy-26 Please don't expose the API_KEY

Solution

  • Create a .env file in your machine, fetch API-KEY from there ( do not push this file )
  • Create a .env.example to let users know how a sample env file should be

@advaita-saha advaita-saha added feature a new feature to be added to the software hacktoberfest issue for hacktoberfest contributions labels Sep 30, 2022
@agnxsh agnxsh self-requested a review October 1, 2022 17:17
@agnxsh
Copy link
Contributor

agnxsh commented Oct 1, 2022

please hide your api keys @srinjoy-26 else we can't merge your pr

@srinjoy-26
Copy link
Contributor Author

please hide your api keys @srinjoy-26 else we can't merge your pr

Since I'm a beginner I'm unable to do it . Please consider and merge.

@agnxsh
Copy link
Contributor

agnxsh commented Oct 1, 2022

youtube mein dekh lo beta @srinjoy-26

@advaita-saha
Copy link
Collaborator

@srinjoy-26
Sorry we cannot accept the PR due to security issues, and dependabots warnings

Please perform the aforesaid changes, so that we can merge it

@advaita-saha advaita-saha added the hacktoberfest-accepted Congratulation, you did a valid request label Oct 2, 2022
@advaita-saha advaita-saha merged commit 5a44a32 into metafy-social:master Oct 2, 2022
@advaita-saha advaita-saha mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a new feature to be added to the software hacktoberfest issue for hacktoberfest contributions hacktoberfest-accepted Congratulation, you did a valid request level-1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weather teller
3 participants