Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion for prepResult.py #8

Closed
apcamargo opened this issue Jul 20, 2020 · 3 comments
Closed

Suggestion for prepResult.py #8

apcamargo opened this issue Jul 20, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@apcamargo
Copy link

Hi!

I've noticed that prepResult.py doesn't support .fna files, which is pretty common for bins. I'd be cool if support for this extension was added.

Also, I noticed that subprocess is not being imported into the script, causing a NameError: name 'subprocess' is not defined error.
@Vini2 Vini2 added the enhancement New feature or request label Jul 20, 2020
@Vini2
Copy link
Collaborator

Vini2 commented Jul 20, 2020

Hello @apcamargo!

Thank you very much for your suggestion. I added support for .fna files in the prepResult.py script.
Commit ID: 1424dba14c8831f76f736e1a700af01a63e0bd66

I also fixed the missing import in prepResult.py script. Thanks for pointing it out.

@apcamargo
Copy link
Author

Thanks!

@Vini2
Copy link
Collaborator

Vini2 commented Jul 20, 2020 •
edited
Loading

Closing issue after including the suggestion.

@Vini2 Vini2 closed this as completed Jul 20, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Vini2 @apcamargo