Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailgun plugin #72

Merged
merged 3 commits into from
Jun 7, 2021
Merged

mailgun plugin #72

merged 3 commits into from
Jun 7, 2021

Conversation

lukvmil
Copy link
Collaborator

@lukvmil lukvmil commented Jun 5, 2021

Finished and test mailgun plugin, ready to merge

@lukvmil lukvmil mentioned this pull request Jun 5, 2021
@gigxz
Copy link
Collaborator

gigxz commented Jun 7, 2021

Looks great! 🙌

django.db.migrations.exceptions.InvalidBasesError: Cannot resolve bases for [<ModelState: 'mailgun.Tutorial'>]
This can happen if you are inheriting models from an app with migrations (e.g. contrib.auth)
in an app with no migrations; see https://docs.djangoproject.com/en/3.2/topics/migrations/#dependencies for more
Error: Process completed with exit code 1.

You need to run python manage.py makemigrations mailgun and commit the migration file that is generated. That should fix the build.

import requests

@Registry.plugin
class Tutorial(Plugin):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename Tutorial->Mailgun

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok great! I'll make those changes

@lukvmil
Copy link
Collaborator Author

lukvmil commented Jun 7, 2021

Made changes and this branch now passes all checks, will merge now!

@lukvmil lukvmil merged commit debcd4f into master Jun 7, 2021
@lukvmil lukvmil deleted the mailgun branch June 7, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants