Slack integration for daily health checks

metagraph-dev · Dec 8, 2020 · 3a4e535 · 3a4e535
1 parent b4ddf35
commit 3a4e535
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 10 deletions.
diff --git a/.github/workflows/daily_checkup.yml b/.github/workflows/daily_checkup.yml
@@ -3,8 +3,8 @@ name: Daily Checkup
 on:
   schedule:
     # * is a special character in YAML so you have to quote this string
-    # Run daily at 10:35pm
-    - cron: '35 22 * * *'
+    # Run daily at 3:35am UTC
+    - cron: '35 3 * * *'
 
 env:
   PYVER: 3.8
@@ -28,16 +28,24 @@ jobs:
           conda install -c ${{ env.CHANNELS }} metagraph-stellargraph
           conda list
       - name: Pytest
-        # TODO: add `pytest --pyargs metagraph_stellargraph` once tests actually exist
         run: |
           source "$CONDA/etc/profile.d/conda.sh"
           conda activate mg
           python -c 'import stellargraph'
-          python -c 'import metagraph_stellargraph.plugins; assert metagraph_stellargraph.plugins.has_stellargraph'
+          pytest --pyargs metagraph_stellargraph
           python -m metagraph.tests
           python -m metagraph.tests --dask
       - name: Notify for Failure
         if: failure()
-        # TODO: replace this with Slack integration
-        run: |
-          echo "I failed!"
+        uses: 8398a7/action-slack@v3
+        with:
+          status: custom
+          custom_payload: |
+            {
+              attachments: [{
+                color: 'danger',
+                text: ':x: Failure\nDaily health check failed for *<https://github.com/metagraph-dev/metagraph-stellargraph/actions?query=workflow%3A%22Daily+Checkup%22|metagraph-stellargraph>*'
+              }]
+            }
+        env:
+          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
diff --git a/.github/workflows/test_and_deploy.yml b/.github/workflows/test_and_deploy.yml
@@ -99,12 +99,11 @@ jobs:
           conda update -c ${{ env.CHANNELS }} metagraph-stellargraph
           conda list
       - name: Pytest
-        # TODO: add `pytest --pyargs metagraph_stellargraph` once tests actually exist
         run: |
           source "$CONDA/etc/profile.d/conda.sh"
           conda activate mg
           python -c 'import stellargraph'
-          python -c 'import metagraph_stellargraph.plugins; assert metagraph_stellargraph.plugins.has_stellargraph'
+          pytest --pyargs metagraph_stellargraph
           python -m metagraph.tests
           python -m metagraph.tests --dask
 

diff --git a/metagraph_stellargraph/plugins/stellargraph/algorithms.py b/metagraph_stellargraph/plugins/stellargraph/algorithms.py
@@ -41,7 +41,7 @@ def sg_connected_components(graph: StellarGraph) -> PythonNodeMapType:
                 index_to_label[node] = i
         return index_to_label
 
-    @concrete_algorithm("util.graph_sage_node_embedding.apply")
+    @concrete_algorithm("embedding.apply.graph_sage")
     def sg_graph_sage_node_embedding_apply(
         embedding: StellarGraphGraphSageNodeEmbedding,
         graph: NetworkXGraph,

diff --git a/metagraph_stellargraph/tests/test_basics.py b/metagraph_stellargraph/tests/test_basics.py
@@ -0,0 +1,5 @@
+from metagraph_stellargraph.plugins import has_stellargraph
+
+
+def test_import():
+    assert has_stellargraph