-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harish-Manifest Json files added #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the template values have been retained which need to be updated.
Oops I'll change and push it |
@Hahkarthick Any updates? |
yes i pushed |
improve name and description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @Hahkarthick
I'd encourage you to take up more issues and solve them ❇️
@xypnox Please approve that this is the right way to generate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a minor discrepancy between the icon sizes and the size of the files they point to files.
Otherwise it looks good to go!
correct the mismatch in image size and image file
#15
Added manifest JSON file and enabled the PWA Add to HomeScreen