Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harish-Manifest Json files added #22

Merged
merged 4 commits into from
Oct 22, 2019
Merged

Conversation

Hahkarthick
Copy link
Contributor

#15
Added manifest JSON file and enabled the PWA Add to HomeScreen

Copy link
Contributor

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the template values have been retained which need to be updated.

manifest.json Outdated Show resolved Hide resolved
@Hahkarthick
Copy link
Contributor Author

Oops I'll change and push it

@thealphadollar
Copy link
Contributor

@Hahkarthick Any updates?

@Hahkarthick
Copy link
Contributor Author

@Hahkarthick Any updates?

yes i pushed

improve name and description
Copy link
Contributor

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @Hahkarthick

I'd encourage you to take up more issues and solve them ❇️

@thealphadollar
Copy link
Contributor

@xypnox Please approve that this is the right way to generate manifest.json.

manifest.json Outdated Show resolved Hide resolved
manifest.json Outdated Show resolved Hide resolved
Copy link

@xypnox xypnox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a minor discrepancy between the icon sizes and the size of the files they point to files.

Otherwise it looks good to go!

correct the mismatch in image size and image file
@thealphadollar thealphadollar merged commit 10367fc into metakgp:master Oct 22, 2019
@thealphadollar thealphadollar mentioned this pull request Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants