-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added flask app #132
added flask app #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from above. Would recommend to have more intuitive names for the endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start @tanush-128
I've added some comments, try to add those changes and its good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it looks better. But a few changes:
- Separate out endpoints for verify otp and download (these two are different things and will be better to be completed in their specific functions)
- Now some name changes
- verify otp -> login
- send otp -> request otp
- create_erp_session -> establish_erp_session
- end_session -> close erp session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. hope you've tested these during development. make these changes and resolve the conversations which are done.
@tanush-128 link this PR to all the issues it is solving |
I can't , I don't have access |
I would directly take the session manager and add it in package, if approved |
Yeah, that is what I'm expecting. If session manager is added in iitkgp-erp-login, we can delete the session_manager.py file and import the session manager directly from iitkgp-erp-login |
yes |
You can create the PR parallely ig? If it's possible then go ahead. Parallely with the logging PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to the following for implementing the backend logic:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rename
server.py
toapp.py
- Use a linter and format the codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohan-b-84 have a look at it once. Green single from my side.
Looks good, @tanush-128 resolve the merge conflicts and we'll merge it. |
@rohan-b-84 I have resolved the conflicts |
fixes #105