Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword based emails from MFTP #5

Closed
icyflame opened this issue Aug 6, 2016 · 2 comments
Closed

Keyword based emails from MFTP #5

icyflame opened this issue Aug 6, 2016 · 2 comments

Comments

@icyflame
Copy link
Member

icyflame commented Aug 6, 2016

This is there as a TODO in the README.

I have understood most of the code now, and I think it will be easy to implement this now. How do you want to do this? This is what I have so far:

  • Have a new collection in the DB that has a list of keywords and the email ID to fire an email to
  • At every diffed notice, search the Notice text for the list of keywords and also the PDF attachment (using some PDF search library)
  • If the keyword matches, then send that email also, otherwise stop.

I have a feeling that all this will take some time? Say 10 users, 4 keywords per user, that's 40 things to search for in the PDF. I am not sure if there's a bottleneck here, and if there is what it is.

@amrav What do you think?

@amrav
Copy link
Member

amrav commented Aug 6, 2016

I now think that this is unnecessary. Email client side filtering is an easier and more powerful approach.

@icyflame
Copy link
Member Author

icyflame commented Aug 6, 2016

Yes, that is correct. Okay, closing this!

@icyflame icyflame closed this as completed Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants