-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable linter, update to g/g 1.30.2, update to go 1.18 #248
Conversation
With just linter fixes we can merge immediately, don't think the Gardener update is necessary right now? |
Build time increased ~1m according to https://github.com/metal-stack/gardener-extension-provider-metal/actions |
I would merge with the g/g update and use this for the next round of g/g update in our environment |
I don't think we need the Gardener dependency update because the other extension providers from them also only have builds for 1.27 or 1.29. |
Also why 1.28.0 and not the latest patch version of this release? |
What about going to 1.30 straight ? |
Can you rebase and maybe even rename the branch? We can soon proceed with Gardener 1.30 and this PR would be great for that. |
Branch rename would make this PR invalid, keep it |
not so important, but mcm-deps could also be bumped: https://github.com/metal-stack/releases/blob/v0.10.2/release.yaml#L54-L61 |
Will do this in the Gardener 1.31 PR. :) |
replaces #214