Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable linter, update to g/g 1.30.2, update to go 1.18 #248

Merged
merged 13 commits into from
Aug 2, 2022

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Apr 28, 2022

replaces #214

@Gerrit91
Copy link
Contributor

With just linter fixes we can merge immediately, don't think the Gardener update is necessary right now?
The linter action introduces double-linting, effectively increasing the build time. Maybe we can try providing an own config file in order not to slow down the build even further: https://github.com/gardener/gardener/blob/v1.27.5/hack/check.sh#L23

@majst01
Copy link
Contributor Author

majst01 commented Apr 28, 2022

With just linter fixes we can merge immediately, don't think the Gardener update is necessary right now? The linter action introduces double-linting, effectively increasing the build time. Maybe we can try providing an own config file in order not to slow down the build even further: https://github.com/gardener/gardener/blob/v1.27.5/hack/check.sh#L23

Build time increased ~1m according to https://github.com/metal-stack/gardener-extension-provider-metal/actions

@majst01
Copy link
Contributor Author

majst01 commented Apr 28, 2022

I would merge with the g/g update and use this for the next round of g/g update in our environment

@Gerrit91
Copy link
Contributor

I don't think we need the Gardener dependency update because the other extension providers from them also only have builds for 1.27 or 1.29.

@Gerrit91
Copy link
Contributor

Also why 1.28.0 and not the latest patch version of this release?

@majst01
Copy link
Contributor Author

majst01 commented Apr 28, 2022

What about going to 1.30 straight ?

@majst01 majst01 changed the title enable linter, update to g/g 1.28, update to go 1.18 enable linter, update to g/g 1.30.2, update to go 1.18 Apr 28, 2022
@Gerrit91
Copy link
Contributor

Gerrit91 commented Jun 8, 2022

Can you rebase and maybe even rename the branch? We can soon proceed with Gardener 1.30 and this PR would be great for that.

@majst01 majst01 requested a review from a team as a code owner June 8, 2022 15:58
@majst01
Copy link
Contributor Author

majst01 commented Jun 8, 2022

Can you rebase and maybe even rename the branch? We can soon proceed with Gardener 1.30 and this PR would be great for that.

Branch rename would make this PR invalid, keep it

@mwennrich
Copy link
Contributor

not so important, but mcm-deps could also be bumped: https://github.com/metal-stack/releases/blob/v0.10.2/release.yaml#L54-L61

@Gerrit91 Gerrit91 merged commit f90385d into master Aug 2, 2022
@Gerrit91
Copy link
Contributor

Gerrit91 commented Aug 2, 2022

Will do this in the Gardener 1.31 PR. :)

@Gerrit91 Gerrit91 deleted the gardener-1.28 branch August 2, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants