Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update netaddr which made all structs opaque, which is good #61

Merged
merged 10 commits into from
Jul 22, 2021

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented May 18, 2021

also move json (de)serialization to separate file

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021

Codecov Report

Merging #61 (aa99184) into master (45aa14d) will increase coverage by 1.90%.
The diff coverage is 84.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   77.11%   79.02%   +1.90%     
==========================================
  Files           5        6       +1     
  Lines         472      553      +81     
==========================================
+ Hits          364      437      +73     
- Misses         57       62       +5     
- Partials       51       54       +3     
Impacted Files Coverage Δ
sql.go 61.25% <62.50%> (-4.73%) ⬇️
prefix.go 80.16% <86.66%> (+1.54%) ⬆️
json.go 87.87% <87.87%> (ø)
ipam.go 100.00% <0.00%> (ø)
postgres.go 71.42% <0.00%> (+1.42%) ⬆️
memory.go 92.45% <0.00%> (+1.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45aa14d...aa99184. Read the comment docs.

@majst01 majst01 marked this pull request as draft May 21, 2021 15:25
@majst01 majst01 mentioned this pull request Jul 11, 2021
@majst01 majst01 marked this pull request as ready for review July 18, 2021 15:29
@majst01 majst01 requested a review from Gerrit91 July 22, 2021 07:05
@Gerrit91 Gerrit91 merged commit 2f3212f into master Jul 22, 2021
@Gerrit91 Gerrit91 deleted the update-netaddr branch July 22, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants