-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ETCD as backend #74
Conversation
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
Nice, thanks for the effort, was thinking also to add this but hadn't enough time. Can you look for the linter errors ? |
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
still a linter issue, try running |
@majst01 hi, the problem is |
you can silent this linter error with `// nolint:gosec`` bevore the line of the complain |
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
Checking all the test now |
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 78.50% 76.28% -2.23%
==========================================
Files 7 8 +1
Lines 642 759 +117
==========================================
+ Hits 504 579 +75
- Misses 74 99 +25
- Partials 64 81 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small nit. Its slightly faster than postgres but 5x more allocs
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
Hi @majst01 I think all is good now |
Awesome, thanks for this contribution. |
I have decided to add ETCD as a new backend since it is well integrated into Kubernetes. All the tests and the benchmarks pass without any problem, but I left that section in the README empty because I run it all in a Macbook pro M1, so I think it would be preferable to run it on the same machine again.