Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ETCD as backend #74

Merged
merged 7 commits into from
May 25, 2022
Merged

Added ETCD as backend #74

merged 7 commits into from
May 25, 2022

Conversation

alejandrojnm
Copy link
Contributor

@alejandrojnm alejandrojnm commented May 23, 2022

I have decided to add ETCD as a new backend since it is well integrated into Kubernetes. All the tests and the benchmarks pass without any problem, but I left that section in the README empty because I run it all in a Macbook pro M1, so I think it would be preferable to run it on the same machine again.

Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
@majst01
Copy link
Contributor

majst01 commented May 24, 2022

Nice, thanks for the effort, was thinking also to add this but hadn't enough time. Can you look for the linter errors ?

Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
@majst01
Copy link
Contributor

majst01 commented May 24, 2022

still a linter issue, try running golangci-lint run -p bugs -p unused locally

@alejandrojnm
Copy link
Contributor Author

@majst01 hi, the problem is TLS InsecureSkipVerify set true. but it is possible to set to true that variable, in our case we use a custom SSL cert so we need to pass InsecureSkipVerify= true.

@majst01
Copy link
Contributor

majst01 commented May 24, 2022

@majst01 hi, the problem is TLS InsecureSkipVerify set true. but it is possible to set to true that variable, in our case we use a custom SSL cert so we need to pass InsecureSkipVerify= true.

you can silent this linter error with `// nolint:gosec`` bevore the line of the complain

Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
@alejandrojnm
Copy link
Contributor Author

Checking all the test now

Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #74 (e1fe134) into master (8b60c49) will decrease coverage by 2.22%.
The diff coverage is 64.10%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   78.50%   76.28%   -2.23%     
==========================================
  Files           7        8       +1     
  Lines         642      759     +117     
==========================================
+ Hits          504      579      +75     
- Misses         74       99      +25     
- Partials       64       81      +17     
Impacted Files Coverage Δ
etcd.go 64.10% <64.10%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b60c49...e1fe134. Read the comment docs.

testing_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@majst01 majst01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small nit. Its slightly faster than postgres but 5x more allocs

Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandrojnm@gmail.com>
@alejandrojnm alejandrojnm requested a review from majst01 May 25, 2022 08:25
@alejandrojnm
Copy link
Contributor Author

Hi @majst01 I think all is good now

@majst01
Copy link
Contributor

majst01 commented May 25, 2022

Awesome, thanks for this contribution.

@majst01 majst01 merged commit 72f3bfa into metal-stack:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants