Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc service #82

Merged
merged 30 commits into from
Jul 26, 2022
Merged

grpc service #82

merged 30 commits into from
Jul 26, 2022

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Jul 24, 2022

In the long run we want to replace the ipam library usage in metal-api with a dedicated microservice. With this PR we provide a grpc service for this purpose.

replaces #46

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2022

Codecov Report

Merging #82 (5a76999) into master (9d82af9) will decrease coverage by 2.64%.
The diff coverage is 56.05%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   74.43%   71.79%   -2.65%     
==========================================
  Files           9       10       +1     
  Lines         935     1092     +157     
==========================================
+ Hits          696      784      +88     
- Misses        130      191      +61     
- Partials      109      117       +8     
Impacted Files Coverage Δ
etcd.go 63.90% <0.00%> (-0.98%) ⬇️
memory.go 93.33% <0.00%> (-3.22%) ⬇️
mongodb.go 62.38% <0.00%> (-1.17%) ⬇️
redis.go 72.34% <0.00%> (-1.58%) ⬇️
sql.go 61.17% <0.00%> (-1.48%) ⬇️
pkg/service/ipam-service.go 59.86% <59.86%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@majst01 majst01 mentioned this pull request Jul 25, 2022
@majst01 majst01 marked this pull request as ready for review July 26, 2022 06:48
@majst01 majst01 requested a review from a team as a code owner July 26, 2022 06:48
Copy link
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, only minor comments added.

.github/workflows/main.yml Outdated Show resolved Hide resolved
cmd/client/client.go Show resolved Hide resolved
pkg/service/ipam-service.go Outdated Show resolved Hide resolved
pkg/service/ipam-service.go Show resolved Hide resolved
pkg/service/ipam-service.go Show resolved Hide resolved
@majst01 majst01 merged commit 56e109e into master Jul 26, 2022
@majst01 majst01 deleted the grpc branch July 26, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants