Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds acquire specific address implementation in ipam service #91

Merged

Conversation

nerdalert
Copy link
Contributor

Implements AcquireSpecificIP in IPAMService resolving #90

Signed-off-by: Brent Salisbury bsalisbu@redhat.com

Implements AcquireSpecificIP in IPAMService resolving metal-stack#90

Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
@nerdalert nerdalert requested a review from a team as a code owner October 29, 2022 07:17
@nerdalert
Copy link
Contributor Author

PTAL at your convenience @majst01. I tested it in the project we are using it for and it worked as advertised. Appreciate you taking a look, cheers!

@majst01
Copy link
Contributor

majst01 commented Oct 29, 2022

PTAL at your convenience @majst01. I tested it in the project we are using it for and it worked as advertised. Appreciate you taking a look, cheers!

Thanks, this was fast :-)

Do you mind telling me your use case ?

@nerdalert
Copy link
Contributor Author

Do you mind telling me your use case ?

For sure! We are doing a POC for edge/iot networking. Was funny, I shared it with another colleague in networking and he was also looking at it for one of their projects so keep up the great work! We will definitely contribute in the future. 🎉

@majst01
Copy link
Contributor

majst01 commented Oct 29, 2022

CI was failing because it tried to push with contributors identity which is actually not supported in our ci setup.

@majst01 majst01 merged commit f12556b into metal-stack:master Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants