Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use one single machine service with cache to reduce metal-api load #71

Merged
merged 9 commits into from
Jun 1, 2023

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented May 20, 2023

This should reduce the load in the metal-api significant because:

  • no more findMachines, always use getMachine by machine ID
  • cache calls for 1 minute to reduce duplicate api calls

should address #49

related to metal-stack/metal-api#443

Do we have machines without ProviderID ? I doubt no

In a next attempt, this should also be done for network calls

@majst01 majst01 requested a review from a team as a code owner May 20, 2023 08:05
pkg/resources/metal/machine.go Outdated Show resolved Hide resolved
pkg/resources/metal/machine.go Outdated Show resolved Hide resolved
@Gerrit91 Gerrit91 merged commit 974c8e8 into master Jun 1, 2023
1 check passed
@Gerrit91 Gerrit91 deleted the reduce-metal-api-load branch June 1, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants