Use service of type LoadBalancer instead of Ingress #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decision was made due to the gardener's default denial of all traffic in the garden namespace, requiring network policies for Ingress controller use. This aligns with the gardener operator's default behavior, as per official documentation: > The virtual-garden-kube-apiserver Deployment is exposed via a Service of type LoadBalancer with the same name. In the future, we will switch to exposing it via Istio, similar to how the kube-apiservers of shoot clusters are exposed. > For the virtual cluster, it is essential to provide a DNS domain via .spec.virtualCluster.dns.domain. The respective DNS record is not managed by gardener-operator and should be manually created and pointed to the load balancer IP of the virtual-garden-kube-apiserver Service. The DNS domain is used for the server in the kubeconfig, and for configuring the --external-hostname flag of the API server.
robertvolkmann
force-pushed
the
loadbalancer-virtual-kube-api-server
branch
from
42849c6
to
39ad105
Compare
robertvolkmann
force-pushed
the
loadbalancer-virtual-kube-api-server
branch
from
69ce488
to
a5dc635
Compare
|
Needs rebase. |
Gerrit91
reviewed
Mar 5, 2024
| {{- if .Values.kubeAPIServer.loadBalancerIP }} | ||
| loadBalancerIP: {{ .Values.kubeAPIServer.loadBalancerIP }} | ||
| {{- end }} | ||
| type: LoadBalancer |
There was a problem hiding this comment.
Can we move the type: LoadBalancer into the if-condition? I would like to maintain the original behavior and do not automatically acquire an IP address if someone forgets to set this.
There was a problem hiding this comment.
We don't set the IP in our setup.
We will default to service type load balancer in the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decision was made due to the gardener's default denial of all traffic in the garden namespace, requiring network policies for Ingress controller use.
This aligns with the gardener operator's default behavior, as per official documentation: