Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move leaf and router role from metal-roles into mini-lab. #281

Merged
merged 7 commits into from
Jun 6, 2024
Merged

Move leaf and router role from metal-roles into mini-lab. #281

merged 7 commits into from
Jun 6, 2024

Conversation

Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Apr 29, 2024 •
edited

References metal-stack/mini-lab#155.

The `leaf` and `router` role were removed from the partition deployment roles because we think only the mini-lab used them. Please make sure not to rely on these roles anymore in your automations.

@Gerrit91 Gerrit91 marked this pull request as ready for review April 29, 2024 11:36
@Gerrit91 Gerrit91 requested a review from a team as a code owner April 29, 2024 11:36
@robertvolkmann robertvolkmann changed the title Move leaf and router role from metal-roles into mini-lab. Move leaf role from metal-roles into mini-lab. Apr 30, 2024
@Gerrit91 Gerrit91 changed the title Move leaf role from metal-roles into mini-lab. Move leaf and router role from metal-roles into mini-lab. May 2, 2024
robertvolkmann
robertvolkmann requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@robertvolkmann robertvolkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still references in partition/Readme.md

@Gerrit91 Gerrit91 merged commit 94a4261 into master Jun 6, 2024
1 check passed
@Gerrit91 Gerrit91 deleted the leaf-and-router branch June 6, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertvolkmann robertvolkmann robertvolkmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gerrit91 @robertvolkmann