Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring members of the gardener soil project #286

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

iljarotar
Copy link

No description provided.

@iljarotar iljarotar requested a review from a team as a code owner June 21, 2024 10:53
@robertvolkmann robertvolkmann marked this pull request as draft June 21, 2024 14:28
@iljarotar iljarotar changed the title Add template for gardener soil project Allow configuring members of the gardener soil project Jun 24, 2024
@@ -123,7 +123,7 @@
k8s:
definition: "{{ lookup('template', 'gardener-soil-project.yaml.j2') }}"
kubeconfig: "{{ gardener_kube_apiserver_kubeconfig_path }}"
when: not lookup('k8s', kubeconfig=gardener_kube_apiserver_kubeconfig_path, api_version='core.gardener.cloud/v1beta1', kind='Project', resource_name=gardener_soil_name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gerrit91 Do you remember why this was necessary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. Maybe the metadata.namespace field was an issue, which is a bit special for this resource. If it works with apply without creating multiple project resources I think we can make this change.

@robertvolkmann robertvolkmann marked this pull request as ready for review July 2, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants