Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for metalctl #142

Closed
GrigoriyMikhalkin opened this issue Aug 8, 2022 · 1 comment
Closed

Tests for metalctl #142

GrigoriyMikhalkin opened this issue Aug 8, 2022 · 1 comment

Comments

@GrigoriyMikhalkin
Copy link
Contributor

At the moment metalctl completely lacks tests. Which makes testing big PRs(example) quite a routine.

Intergration tests would be a great addition. Another, lighter, solution would be adding unit tests with using metal-go mock client.

This issue seems to be quite massive to solve it in one PR. Solving it by parts(smaller PRs adding small test coverage) should be more feasible.

cc @Gerrit91
@Gerrit91
Copy link
Contributor

All base commands now have unit test coverage (through #146).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GrigoriyMikhalkin @Gerrit91