Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Generic CLI commands. #140

Merged
merged 37 commits into from
Aug 10, 2022
Merged

Refactoring: Generic CLI commands. #140

merged 37 commits into from
Aug 10, 2022

Conversation

Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Jul 7, 2022

No description provided.

@Gerrit91 Gerrit91 changed the title Introduce generic applier. Introduce generic CLI commands. Jul 7, 2022
@Gerrit91 Gerrit91 changed the title Introduce generic CLI commands. Recatoring: Generic CLI commands. Jul 20, 2022
@Gerrit91 Gerrit91 changed the title Recatoring: Generic CLI commands. Refactoring: Generic CLI commands. Jul 20, 2022
@GrigoriyMikhalkin GrigoriyMikhalkin mentioned this pull request Aug 8, 2022
Closed
GrigoriyMikhalkin
GrigoriyMikhalkin approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@GrigoriyMikhalkin GrigoriyMikhalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested some functionality locally(mostly project and machine parts). Everything worked so far, but some behavior tests of most critical parts would be nice.

@Gerrit91 Gerrit91 marked this pull request as ready for review August 10, 2022 07:37
@Gerrit91 Gerrit91 requested a review from a team as a code owner August 10, 2022 07:37
@Gerrit91
Copy link
Contributor Author

Thanks for taking a look. I know it's a bit too large for easy review. :/

As we are using this PR now for a couple of weeks, I think we should be pretty much good to go. So I will merge the PR now but not yet release metalctl and then make more adjustments and add tests. Otherwise this PR gets even bigger and then review will again be difficult.

@Gerrit91 Gerrit91 merged commit 7f52ab4 into master Aug 10, 2022
@Gerrit91 Gerrit91 deleted the generic-applier branch August 10, 2022 07:42
@Gerrit91 Gerrit91 mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrigoriyMikhalkin GrigoriyMikhalkin GrigoriyMikhalkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gerrit91 @GrigoriyMikhalkin