Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall rules #233

Merged
merged 8 commits into from
Feb 16, 2024
Merged

Firewall rules #233

merged 8 commits into from
Feb 16, 2024

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Feb 7, 2024

No description provided.

@majst01 majst01 marked this pull request as ready for review February 16, 2024 10:12
@majst01 majst01 requested a review from a team as a code owner February 16, 2024 10:12
@vknabel
Copy link
Contributor

vknabel commented Feb 16, 2024

Do we want to support reading the firewall rules from stdin? (not sure about the flag)
It would be quite handy to manually create a firewall without creating a temporary file.

$ metalctl firewall create ..mandatory args.. --firewall-rules-file - << RULES
---
egress:
- comment: allow outgoing https
  ports:
  - 443
  protocol: TCP
  to:
  - 0.0.0.0/0
RULES

@majst01
Copy link
Contributor Author

majst01 commented Feb 16, 2024

Do we want to support reading the firewall rules from stdin? (not sure about the flag) It would be quite handy to manually create a firewall without creating a temporary file.

$ metalctl firewall create ..mandatory args.. --firewall-rules-file - << RULES
---
egress:
- comment: allow outgoing https
  ports:
  - 443
  protocol: TCP
  to:
  - 0.0.0.0/0
RULES

Would be nice, but i would really like to stop spending time on this rarely used feature

cmd/firewall.go Outdated Show resolved Hide resolved
@majst01 majst01 merged commit fbe89a5 into master Feb 16, 2024
5 checks passed
@majst01 majst01 deleted the firewall-rules branch February 16, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants