Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential nil access spotted by nilaway #3

Merged
merged 1 commit into from Jan 9, 2024
Merged

Fix potential nil access spotted by nilaway #3

merged 1 commit into from Jan 9, 2024

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Jan 9, 2024

nilaway found this:

nilaway ./...
/home/stefan/dev/github.com/metal-stack/oci-mirror/pkg/mirror/mirror.go:130:22: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
        -> mirror/mirror.go:130:22: unassigned variable `semverTags` sliced into

@majst01 majst01 requested a review from a team as a code owner January 9, 2024 07:24
@majst01 majst01 requested a review from mwennrich January 9, 2024 07:25
@majst01 majst01 merged commit 5412b22 into main Jan 9, 2024
1 check passed
@majst01 majst01 deleted the fix-potential-npe branch January 9, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwennrich mwennrich mwennrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@majst01 @mwennrich