Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also update username when credentials are updated #225

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

diogomatsubara
Copy link
Contributor

During an upsert of server credentials, if the username changed, it needs to be updated as well.

During an upsert of server credentials, if the username changed, it
needs to be updated as well.
@diogomatsubara diogomatsubara requested a review from a team as a code owner August 8, 2023 10:01
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #225 (479c6e2) into main (94b3a8b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   71.69%   71.72%   +0.02%     
==========================================
  Files          36       36              
  Lines        3466     3469       +3     
==========================================
+ Hits         2485     2488       +3     
  Misses        734      734              
  Partials      247      247              
Flag Coverage Δ
unittests 71.72% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/api/v1/router_server_secrets.go 71.77% <100.00%> (+0.69%) ⬆️

joelrebel
joelrebel previously approved these changes Aug 8, 2023
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diogomatsubara nice find! It would be worth updating the test

t.Run("updates when secret already exist", func(t *testing.T) {

@diogomatsubara
Copy link
Contributor Author

Thanks for the review @joelrebel, updated the test as well.

Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@diogomatsubara diogomatsubara merged commit 87a0c2b into main Aug 8, 2023
7 checks passed
@diogomatsubara diogomatsubara deleted the fix-credentials-username-update branch August 8, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants