Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination support to ComponentFirmwareVersion #227

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

diogomatsubara
Copy link
Contributor

No description provided.

@diogomatsubara diogomatsubara requested a review from a team as a code owner August 14, 2023 16:32
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #227 (56d2169) into main (accfa6f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   71.73%   71.74%           
=======================================
  Files          36       36           
  Lines        3527     3528    +1     
=======================================
+ Hits         2530     2531    +1     
  Misses        745      745           
  Partials      252      252           
Flag Coverage Δ
unittests 71.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/api/v1/firmware_list_params.go 100.00% <100.00%> (ø)

Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@diogomatsubara diogomatsubara merged commit 84744ff into main Aug 16, 2023
7 checks passed
@diogomatsubara diogomatsubara deleted the firmware-pagination branch August 16, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants