-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
Changes Unknown when pulling 955eb02 on carloslancha:coverage into ** on metal:master**. |
package.json
Outdated
@@ -3,8 +3,9 @@ | |||
"scripts": { | |||
"a11y": "metal-a11y --packages ./packages -c demos/index.html", | |||
"build": "lerna run build", | |||
"ci": "npm run build && npm run checkFormat && npm run lint && npm run test", | |||
"ci": "npm run build && npm run checkFormat && npm run lint && npm run test && npm run coveralls", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think the using CI configurations in travis.yml
?
script:
- npm run build
- npm run checkFormat
- npm run lint
- npm run test
# Coveralls
after_success: npm run coveralls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
Hey @carloslancha, Coveralls exist a feature that fails in pr when coverage is reduced. Are we using this? |
Hey @matuzalemsteles nope, for that I think we need to get on an agreement on how that should work, if should fail when coverage is reduced, if is reduced down a defined threshold... What do you think? |
Changes Unknown when pulling 69a5f8e on carloslancha:coverage into ** on metal:master**. |
If we enable it, we should add the coverage badge to the |
@carloslancha Yeah, it has the option of when a PR reduces x% coverage of the repo it fails and we can also put the minimum coverage. I do not have the right margin to measure this. I think we can go without it for now and when we realize that it is not having a good coverage we can measure this percentage better. Do you have any suggestions about this? |
Sure thing @jbalsas I was waiting for the first report to get the url ;) |
@matuzalemsteles Yeah, I think we can adjust it later, maybe after talking with te rest of the team :) |
Changes Unknown when pulling 92ea959 on carloslancha:coverage into ** on metal:master**. |
@carloslancha Okay. Merged, thanks! |
No description provided.