Coverage

[carloslancha]

No description provided.

[coveralls]

Changes Unknown when pulling 955eb02 on carloslancha:coverage into ** on metal:master**.

[matuzalemsteles]

What do you think the using CI configurations in travis.yml?

script:
  - npm run build
  - npm run checkFormat
  - npm run lint
  - npm run test

# Coveralls
after_success: npm run coveralls

[carloslancha]

Sounds good!

[matuzalemsteles]

Hey @carloslancha, Coveralls exist a feature that fails in pr when coverage is reduced. Are we using this?

[carloslancha]

Hey @matuzalemsteles nope, for that I think we need to get on an agreement on how that should work, if should fail when coverage is reduced, if is reduced down a defined threshold... What do you think?

[coveralls]

Changes Unknown when pulling 69a5f8e on carloslancha:coverage into ** on metal:master**.

[jbalsas]

If we enable it, we should add the coverage badge to the README.md file as well 😉

[matuzalemsteles]

@carloslancha Yeah, it has the option of when a PR reduces x% coverage of the repo it fails and we can also put the minimum coverage. I do not have the right margin to measure this. I think we can go without it for now and when we realize that it is not having a good coverage we can measure this percentage better. Do you have any suggestions about this?

[carloslancha]

Sure thing @jbalsas I was waiting for the first report to get the url ;)

[carloslancha]

@matuzalemsteles Yeah, I think we can adjust it later, maybe after talking with te rest of the team :)

[coveralls]

Changes Unknown when pulling 92ea959 on carloslancha:coverage into ** on metal:master**.

[matuzalemsteles]

@carloslancha Okay.

Merged, thanks!