This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Rename pattern to tiles and add default point patterns #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2017 12:58
and rename template namespace
jbalsas
reviewed
Dec 20, 2017
packages/clay-charts/package.json
Outdated
| "sass": "node-sass src/scss/main.scss -o lib/css --source-map true", | ||
| "soy": "metalsoy --soyDeps node_modules/metal*/src/**/*.soy node_modules/clay*/src/**/*.soy" | ||
| "soy": "metalsoy --soyDeps node_modules/metal*/src/**/*.soy node_modules/clay*/src/**/*.soy", | ||
| "copy": "ncp src/svg lib/svg" |
There was a problem hiding this comment.
let's call this maybe copyAssets? or copySvg? :)
jbalsas
reviewed
Dec 20, 2017
| @@ -1,55 +1,46 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
Which would be the way to insert this in the DOM in an inert way? (not showing)
There was a problem hiding this comment.
@jbalsas for the moment we can use <svg ... width="0" height="0"> or <svg ... style="display:none"> until we find the "idiomatic" way of doing it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.