Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds metal-assertions module to packages #213

Closed
wants to merge 1 commit into from
Closed

Adds metal-assertions module to packages #213

wants to merge 1 commit into from

Conversation

julien
Copy link
Contributor

@julien julien commented Mar 3, 2017

No description provided.

@yuchi
Copy link
Contributor

yuchi commented Mar 3, 2017

Travis error:

Chrome Mobile 30.0.0 (Android 4.4.2) assertions assertPromise should not throw error when it's a promise FAILED
	AssertionError: expected [Function] to not throw an error but 'ReferenceError: Promise is not defined' was thrown
	    at Function.assert.doesNotThrow (node_modules/chai/chai.js:3300:35)
	    at Context.<anonymous> (/tmp/packages/metal-assertions/test/assertions.js:155:10 <- /tmp/49c588b42ef076332fde45f12773d68b.browserify:695:11)

@julien
Copy link
Contributor Author

julien commented Mar 3, 2017 •
edited

@yuchi thanks! just saw it.

Which Promise polyfill do you usually use?

@julien julien closed this Mar 3, 2017
@julien julien deleted the metal-assertions branch March 3, 2017 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julien @yuchi