Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Test virtualmedia boot #1512

Closed
lentzi90 opened this issue Jan 9, 2024 · 3 comments · Fixed by #1520
Closed

E2E: Test virtualmedia boot #1512

lentzi90 opened this issue Jan 9, 2024 · 3 comments · Fixed by #1520
Assignees
Labels
triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@lentzi90
Copy link
Member

lentzi90 commented Jan 9, 2024

Test virtualmedia boot in the e2e tests. We have a live-iso test already here, but this just sets the disk format. The idea with the live-iso test that we have in CAPM3 is to test virtualmedia booting with a live-iso and that would be good to test here as well.

I think we have two alternatives:

  1. Make the live-iso test "special". It would require redfish-virtualmedia or skip the test
  2. Make all tests work with virtualmedia. Just like we currently test with IPMI and redfish, this would just be another option. In this case the live-iso test stays like it is now but we may have to adapt other tests to work with virtualmedia (e.g. disk cleaning could be strange).

I would prefer option 2.

@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Jan 9, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Jan 9, 2024

/cc @Rozzii

@Rozzii
Copy link
Member

Rozzii commented Jan 16, 2024

I would prefer option 2 we are doing it in CAPM3 tests as out of the 4 nodes some are using virtualmedia to boot. This is also an easy test, you just add the prefix to the bmc address. I don't really expect issues even with disk cleaning, IPA should handle that just fine .
/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Jan 16, 2024
@lentzi90
Copy link
Member Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants