Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need tags for ironic-image releases #1663

Closed
mquhuy opened this issue Apr 11, 2024 · 6 comments
Closed

We need tags for ironic-image releases #1663

mquhuy opened this issue Apr 11, 2024 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@mquhuy
Copy link
Member

mquhuy commented Apr 11, 2024

What steps did you take and what happened:

  • Install ironic with a release ironic-image image, for e.g.
images: 
- name: quay.io/metal3-io/ironic                
  newTag: release-24.0

but the ironic deployment won't be ready, as the release-24.0 image lacks the readiness and liveness probes, which is required by the main branch ironic-deployment kustomization.

What did you expect to happen:
We should have an ironic-image-release-24.0 tag in BMO repo, which should be used to get a suitable kustomization that works with the release-24.0 ironic image

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Maybe it makes more sense to store the ironic-deployment in ironic-image repo instead? The kustomization will, then, be a part of the release branches/tags.

/kind bug

@metal3-io-bot metal3-io-bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 11, 2024
@metal3-io-bot
Copy link
Contributor

This issue is currently awaiting triage.
If Metal3.io contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Apr 11, 2024
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 10, 2024
@Rozzii
Copy link
Member

Rozzii commented Jul 10, 2024

The 0.5 release branch of BMO supports 24.0 Ironic image wouldn't that fulfill your requirement?

@Rozzii
Copy link
Member

Rozzii commented Jul 10, 2024

/remove-lifecycle stale
/triage needs-information

@metal3-io-bot metal3-io-bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 10, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Jul 10, 2024

The 0.5 release branch of BMO supports 24.0 Ironic image wouldn't that fulfill your requirement?

Kinds of. But that's more of suitability between BMO versions and ironic versions. The problem I'm mentioning here is how an ironic-deployment version should be suitable to an ironic-image version.

I guess the main issue here is that we have ironic deployment and ironic-image in two repos.

@mquhuy
Copy link
Member Author

mquhuy commented Jul 10, 2024

We discussed in the community meeting. The current situation is fine for now, as we will eventually move to ironic-standalone-operator instead.

@mquhuy mquhuy closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

3 participants