Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need tags for ironic-image releases #1663

Open
mquhuy opened this issue Apr 11, 2024 · 1 comment
Open

We need tags for ironic-image releases #1663

mquhuy opened this issue Apr 11, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue lacks a `triage/foo` label and requires one.

Comments

@mquhuy
Copy link
Member

mquhuy commented Apr 11, 2024

What steps did you take and what happened:

  • Install ironic with a release ironic-image image, for e.g.
images: 
- name: quay.io/metal3-io/ironic                
  newTag: release-24.0

but the ironic deployment won't be ready, as the release-24.0 image lacks the readiness and liveness probes, which is required by the main branch ironic-deployment kustomization.

What did you expect to happen:
We should have an ironic-image-release-24.0 tag in BMO repo, which should be used to get a suitable kustomization that works with the release-24.0 ironic image

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Maybe it makes more sense to store the ironic-deployment in ironic-image repo instead? The kustomization will, then, be a part of the release branches/tags.

/kind bug

@metal3-io-bot metal3-io-bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 11, 2024
@metal3-io-bot
Copy link
Contributor

This issue is currently awaiting triage.
If Metal3.io contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants