Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metal3Data deletable while in-use #1356

Closed
lentzi90 opened this issue Dec 12, 2023 · 5 comments · Fixed by #1478
Closed

Metal3Data deletable while in-use #1356

lentzi90 opened this issue Dec 12, 2023 · 5 comments · Fixed by #1478
Assignees
@lentzi90
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@lentzi90
Copy link
Member

What steps did you take and what happened:

  1. Create a Cluster with Metal3 for infra and include a Metal3DataTemplate
  2. Wait for all Machines to be Ready
  3. Delete a Metal3Data or Metal3DataClaim
  4. The Metal3Data or Metal3DataClaim is directly deleted, including the rest of the objects in the owner chain (Metal3DataClaim, Metal3Data, IPClaim, IPAddress and secrets for metadata and network data)

What did you expect to happen:

The objects should be protected from deletion while in use, i.e. even when deletion is triggered they should have finalizers that their controllers do not remove if they are still in-use.

Environment:

  • Cluster-api version: v1.5.3
  • Cluster-api-provider-metal3 version: v1.5.2
  • Ip-address-manager: v1.5.2
  • Environment (metal3-dev-env or other): other
  • Kubernetes version: (use kubectl version): v1.28.3

/kind bug
@metal3-io-bot metal3-io-bot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 12, 2023
@lentzi90
Copy link
Member Author

/triage accepted
/cc @Rozzii

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 12, 2023
@lentzi90 lentzi90 mentioned this issue Dec 12, 2023
Closed
@Rozzii Rozzii added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 17, 2023
@maxrantil
Copy link
Member

/assign

@maxrantil maxrantil mentioned this issue Feb 28, 2024
Merged
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2024
@lentzi90
Copy link
Member Author

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 20, 2024
@lentzi90
Copy link
Member Author

/assign

@maxrantil maxrantil removed their assignment May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lentzi90 lentzi90

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Protect Metal3Data and Metal3DataClaim with Finalizers Nordix/cluster-api-provider-metal3
4 participants
@lentzi90 @Rozzii @metal3-io-bot @maxrantil