Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OutOfServiceTaint to Node Instead of Deleting Node Object #1725

Open
clobrano opened this issue May 20, 2024 · 4 comments
Open

Add OutOfServiceTaint to Node Instead of Deleting Node Object #1725

clobrano opened this issue May 20, 2024 · 4 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@clobrano
Copy link

User Story

As an operator, I would like to add an OutOfServiceTaint to a Node instead of deleting the Node
object.

  • use core functionality to obtain the same goal is a cleaner approach
  • no need to backup and restore the Node

Detailed Description

For Kubernetes >= 1.28
Add the out-of-service taint in place of deleting the Node object Kubernetes >= 1.28

For Kubernetes < 1.28
Keep the current behavior

Anything else you would like to add:

/kind feature

@metal3-io-bot metal3-io-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels May 20, 2024
@clobrano
Copy link
Author

I introduced this request on slack and I'd like to implement it

@Rozzii
Copy link
Member

Rozzii commented Jun 12, 2024

Previous proposal: #367
K8s feature related info: https://kubernetes.io/blog/2023/08/16/kubernetes-1-28-non-graceful-node-shutdown-ga/
I am okay with this:
/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Jun 12, 2024
@clobrano
Copy link
Author

Great, working on it

@clobrano
Copy link
Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants