Allow passing a -s parameter, use it as the destination URL scheme #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to proxy to https services (effectively unwrapping the HTTPS at the cors proxy).
metal3d
reviewed
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to proxy to an https service, and couldn't figure out the right way to set up cors-proxy such that it would do this; the
r.TLScheck seemed wrong (or rather, unachievable since I didn't give the cors-proxy server a certificate or key), so I decided to make cors-proxy effectively unwrap TLS from the requests: A client sends an HTTP request to cors-proxy, and cors-proxy makes an HTTPS request to the destination service.Additionally, this fixes a typo in parameter validation.
Hope you find this and #1 acceptable - with these two, I could successfully proxy to an HTTPS JSON API in a dev environment! (-: