Added searchbox placeholder and pod/deployment filters #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecDialog.kt
Outdated
Show resolved
Hide resolved
eyalb181
reviewed
Jun 27, 2023
modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecDialog.kt
Outdated
Show resolved
Hide resolved
|
Minor change - last selected target is now always at the top if it's not filtered out |
eyalb181
approved these changes
Jun 29, 2023
infiniteregrets
approved these changes
Jun 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
Screencast from 26.06.2023 14:22:50.webm (listing deployments in
mirrord lsis not yet released, so no deployments in the dialog)