Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give config info at session start #2447

Merged
merged 5 commits into from
May 17, 2024
Merged

Conversation

gememma
Copy link
Contributor

@gememma gememma commented May 15, 2024

Closes #2367

@aviramha
Copy link
Member

Can you attach a GIF to show how it looks in CLI/IDE please?

@gememma
Copy link
Contributor Author

gememma commented May 15, 2024

Ah. I completely forgot about the plugins - I'll mark this as a draft and make sure they look good too

@gememma gememma marked this pull request as draft May 15, 2024 17:04
@gememma
Copy link
Contributor Author

gememma commented May 15, 2024

For the record, this is how it looks in the CLI:
print_config

mirrord/cli/src/main.rs Outdated Show resolved Hide resolved
mirrord/cli/src/main.rs Outdated Show resolved Hide resolved
@gememma
Copy link
Contributor Author

gememma commented May 17, 2024

VSCode plugin

collapsed (default)

popup_custom_config_collapsed

expanded

popup_custom_config

IntelliJ plugin

collapsed (default)

popup_custom_intellij_collapsed

expanded

popup_custom_intellij

@gememma gememma marked this pull request as ready for review May 17, 2024 14:36
@eyalb181
Copy link
Member

VSCode plugin

collapsed (default)

popup_custom_config_collapsed

expanded

popup_custom_config

IntelliJ plugin

collapsed (default)

popup_custom_intellij_collapsed

expanded

popup_custom_intellij

@aviramha @Razz4780 @gememma Thoughts about this?

IMO doesn't look great, but perhaps there's a way for us to show this in a persistent UI component within the IDE? Even just mirrord dropdown menu -> Session Status which would make a popup show up. This has the advantage of letting the user check the status throughout the entire session, not just at the start.

@aviramha
Copy link
Member

IMO doesn't look great, but perhaps there's a way for us to show this in a persistent UI component within the IDE? Even just mirrord dropdown menu -> Session Status which would make a popup show up. This has the advantage of letting the user check the status throughout the entire session, not just at the start.

Having a persistent UI component has been itching me for a while but I think it should be out of scope for this specific issue. It'd require more design and architecture decisions.
We can consider not having this feature in IDEs for now.

@eyalb181
Copy link
Member

IMO doesn't look great, but perhaps there's a way for us to show this in a persistent UI component within the IDE? Even just mirrord dropdown menu -> Session Status which would make a popup show up. This has the advantage of letting the user check the status throughout the entire session, not just at the start.

Having a persistent UI component has been itching me for a while but I think it should be out of scope for this specific issue. It'd require more design and architecture decisions. We can consider not having this feature in IDEs for now.

@gememma In that case, lets just not have this in the IDEs for the moment. Instead, please open follow-up issues in IntelliJ and VS Code to display this in a persistent component.

@Razz4780
Copy link
Contributor

@aviramha @Razz4780 @gememma Thoughts about this?

IMO doesn't look great, but perhaps there's a way for us to show this in a persistent UI component within the IDE? Even just mirrord dropdown menu -> Session Status which would make a popup show up. This has the advantage of letting the user check the status throughout the entire session, not just at the start.

  1. VSCode - I'm not sure if we can do better. I don't think notifications respect newlines + there's no "popup" concept in VSCode. We can only use notifications, quickpick, open a new editor tab prefilled with text 🤷
  2. IntelliJ - we can do a popup, yeah

Regardless, this is what it's going to look like in old plugin/extension versions. Unless we come up with something very cunning

@eyalb181
Copy link
Member

@aviramha @Razz4780 @gememma Thoughts about this?
IMO doesn't look great, but perhaps there's a way for us to show this in a persistent UI component within the IDE? Even just mirrord dropdown menu -> Session Status which would make a popup show up. This has the advantage of letting the user check the status throughout the entire session, not just at the start.

  1. VSCode - I'm not sure if we can do better. I don't think notifications respect newlines + there's no "popup" concept in VSCode. We can only use notifications, quickpick, open a new editor tab prefilled with text 🤷
  2. IntelliJ - we can do a popup, yeah

Regardless, this is what it's going to look like in old plugin/extension versions. Unless we come up with something very cunning

The left sidebar is probably a good candidate for this on vs code

@gememma
Copy link
Contributor Author

gememma commented May 17, 2024

Having a persistent UI component has been itching me for a while but I think it should be out of scope for this specific issue. It'd require more design and architecture decisions. We can consider not having this feature in IDEs for now.

@gememma In that case, lets just not have this in the IDEs for the moment. Instead, please open follow-up issues in IntelliJ and VS Code to display this in a persistent component.

I agree that this wall-of-text-style notification isn't very nice to look at or parse for details. I'll remove the call in the extension code and at least we know that the information itself is easily sent to the IDE when we figure out the best way to present it. I can also open some issues to track that 👍 thanks all @aviramha @eyalb181 @Razz4780

@gememma gememma added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@Razz4780 Razz4780 added this pull request to the merge queue May 17, 2024
Merged via the queue into metalbear-co:main with commit b57c074 May 17, 2024
16 checks passed
@aviramha aviramha mentioned this pull request May 19, 2024
9 tasks
@gememma gememma deleted the give-config-info branch May 22, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide explanation before session start
4 participants